search

JTeeuwissen / json-logic-haskell

JsonLogic library for Haskell
MIT License
0 stars 0 forks source link

84 enable simple json parsing and use ov #136

Closed JTeeuwissen closed 2 years ago

JTeeuwissen commented 2 years ago

resolves #84

musicismyalibi commented 2 years ago

Is there a reason that we create our own JSON parser instead of using an existing one like Aeson?

JTeeuwissen commented 2 years ago

Is there a reason that we create our own JSON parser instead of using an existing one like Aeson?

Yes, although JsonLogic with Aeson is fine. Especially when already using Aeson. It can be a lot of overhead for a simpler project. This functionality is nice for demos without having to rely on a relatively big package.

musicismyalibi commented 2 years ago

I think it might be better to put the JSON parsing in a separate file.

JTeeuwissen commented 2 years ago

I think it might be better to put the JSON parsing in a separate file.

I wanted to do so, but that would make it an orphan instance. And moving just the parsing (not the instance) causes circular dependencies.