search

JULIELab / trec-pm

Support code and resources for participation at the TREC Precision Medicine Track (TREC-PM)
http://trec-cds.appspot.com
MIT License
9 stars 2 forks source link

Templatedecoratorrework #115

Closed khituras closed 4 years ago

khituras commented 4 years ago

Integrated the new JsonTemplateQueryDecorator that works with templates which adhere to the JSON syntax. Please check if I forgot an important functionality. All features are described in the documentation of the README.md file.

michelole commented 4 years ago

Shouldn't we update all old templates?

khituras commented 4 years ago

Ideally, yes. But we would need to test them all. Seems like quite some work. On the other hand, the old decorators still work and thus, so do the old templates. You think it would be important to update them and delete the old decorators all the same?

michelole commented 4 years ago

I'd say it could be confusing to have two competing "template engines".

Maybe that could be a follow up work if it's too much to do now --- we could then also clean up outdated templates/decorators.

khituras commented 4 years ago

You're right, it would be confusing and I'm not a fan myself. Feel free to start the process. I'd join but I won't do it alone.