search

JULIELab / trec-pm

Support code and resources for participation at the TREC Precision Medicine Track (TREC-PM)
http://trec-cds.appspot.com
MIT License
9 stars 2 forks source link

`Retrieval` should not depend on year #50

Closed michelole closed 5 years ago

michelole commented 5 years ago

It's confusing that both Experiment and the encapsulated Retrieval depend on year.

Experiment requires it to guess the topics to load (given also the Task), which makes sense.

However, Retrieval uses it only for the experimentID, which is misleading. Moreover, Retrieval is designed to accept topics from different years (via the retrieve method), so it should not fix a single year.

khituras commented 5 years ago

Agreed. This, and a few other quirks, exist because I wanted to keep compatibility with the old experimental code. We are free to change that now.