Negative boosts are not supported in ES 7

JULIELab / trec-pm

Support code and resources for participation at the TREC Precision Medicine Track (TREC-PM)

http://trec-cds.appspot.com

MIT License

9 stars 2 forks source link

Negative boosts are not supported in ES 7 #73

Open michelole opened 5 years ago

michelole commented 5 years ago

Used for negative_boosters.json, match_all.json, and other.json.

negative_boosters.json and other.json should be migrated to query boosting. Caveat: static boosting might lead to different results (better? worse? same?)
match_all.json: boost = 0
other.json could also be migrated to a should_not query.

Test with 2017 and 2018 data. Validate on internal 2019 GS.

michelole commented 5 years ago

@khituras other.json (used to downrank matches on comorbidities in CT exclusion criteria) also has a negative boost. However, it doesn't happen together with negative_boosters.json (used only for BA).

michelole commented 5 years ago

Worst case scenario we could try a must_not clause. Update: they don't seem to improve results either.

michelole commented 5 years ago

match_all could be switched to a match on any "cancer" or "gene"/"mutation".

michelole commented 5 years ago

This is being solved by reverting back to an ES 5.4 index (see also #84).