Closed abomb60 closed 7 months ago
Thanks! I'll work this into an update. I will change it a bit though so it's compatible across the board. My implementation will probably add new regex within "beginxrit/endxrit" sections to keep from breaking goestools compatibility.
Once I push the changes I'll ask you to test, since I don't have the software. Thanks again!
@abomb60 I already pushed the changes - no release yet, but can you test against the latest main branch? Make sure to update your dataHandler.php, and use the new sample configs in the /configs
dir to make sure they work.
You'll probably notice the only real difference between my configs and yours is that my changes require adding mode = "xrit"
to each handler, since my new dataHandler is looking for it.
Thanks for looking at this request so quickly! I will grab the code and test it out later today/tomorrow.
@abomb60 have you had a chance to test the changes?
I'm going to close this for now since my implementation should work, but if there are issues, feel free to let me know!
Discussed in https://github.com/JVital2013/vitality-goes/discussions/46