search

JWST-MIRI / MiriTE

Miri Tools Environment
Other
1 stars 5 forks source link

MIRI-676, MIRI-845: update ancestry #32

Closed vcgeers closed 3 years ago

vcgeers commented 3 years ago

This adds mapping for LRS APCORR and MRS APCORR, based on datamodels defined in "jwst" at: https://github.com/spacetelescope/jwst/blob/master/jwst/datamodels/apcorr.py

vcgeers commented 3 years ago

Based on an update from David on MIRI-845, it's clear that the JWST datamodel for MRS APCORR is not necessarily the same as for the original MRS APERCORR files delivered in CDP-7.

Since there are currently no clear plans to provide updated files for CDP-8, it's premature to add the mapping for MRS, so I've reverted that change, so this PR just focusses on the mapping for LRS.

smbeard commented 3 years ago

Yes, the change looks ok to me, as long as there is an equivalent JWST data model called MirLrsApcorrModel which can also open these files.

I notice you reverted the MRS change, I presume because there isn't an MRS equivalent available in the JWST data models.

vcgeers commented 3 years ago

Thanks Steven.

I reverted the MRS change because while there is a JWST data model called "MirMrsApcorrModel", I understand from David Law that it is not necessarily equivalent to our data model. Our data model is still appropriate for the CDP-7 files we delivered. STScI's data model is for an updated version they created from the CDP-7 file. Until we decide to deliver a newer version, there is no point in updated our MRS model.