search

JWWeatherman / yeticold

https://yeticold.com
Other
66 stars 24 forks source link

fix(deps): bump bip32 python module to v3.4 #179

Closed epiccurious closed 2 months ago

epiccurious commented 3 months ago

Closes #178.

The version Yeti's currently installing is 3.1, but that version doesn't exist in the pip repository.

if not subprocess.run("python3 -c 'import bip32' 2> /dev/null", shell=True, check=False).returncode == 0:
    subprocess.run('pip3 install bip32==3.1', shell=True, check=False)

Running pip install bip32 on my local machine installs version 3.4.

To fix, bump the version in initialize to pip install bip32=3.4.

epiccurious commented 3 months ago

Setting as a draft to test the initialization process on Ubuntu 24, 22, and 20.

epiccurious commented 3 months ago

Tested on Proxmox VMs running Ubuntu 24, 22, and 20. MR is ready for review.

epiccurious commented 3 months ago

The issue is with coincurve, which is a dependency for bip32.

Tried all three of these on a fresh install of Ubuntu 24, but they fail for 'NoneType' object is not callable:

pip3 install bip32==3.1
pip3 install bip32==3.4
pip3 install bip32
epiccurious commented 3 months ago

When you run pip3 install bip32, it pulls in a coincurve version < 19 and >= 15.0, so it grabs version 18, which fails.

Also, pip3 install coincurve==18 fails.

The next step might be to open an issue upstream on the coincurvew repo. This issue doesn't seem to have been opened yet - see link.