JWally / tadpoles-media-downloader

Hack method to download all of your media from tadpoles.com
17 stars 11 forks source link

quotes #1

Open MarredCheese opened 3 years ago

MarredCheese commented 3 years ago

Awesome work you've done here. Just wanted to let you know of a minor but pesky issue:

Copying the code below from this repo directly works fine: javascript:var js = document.createElement('script');js.src = 'https://jwally.github.io/tadpoles-media-downloader/index.js';document.querySelectorAll('head')[0].appendChild(js).

But copying it from https://jwally.github.io/tadpoles-media-downloader/ does not work because the single quotation marks have been converted to fancy-pants directional quotation marks. javascript:var js = document.createElement(‘script’);js.src = ‘https://jwally.github.io/tadpoles-media-downloader/index.js’;document.querySelectorAll(‘head’)[0].appendChild(js)

JWally commented 3 years ago

Thanks! I swapped up the mark down to put the string to be copied in a code-block so github is less tempted to mangle it.

-JWW

On Tue, Sep 7, 2021 at 10:23 AM MarredCheese @.***> wrote:

Awesome work you've done here. Just wanted to let you know of a minor but pesky issue:

Copying the code below from this repo directly works fine: javascript:var js = document.createElement('script');js.src = ' https://jwally.github.io/tadpoles-media-downloader/index.js';document.querySelectorAll('head')[0].appendChild(js) .

But copying it from https://jwally.github.io/tadpoles-media-downloader/ does not work because the single quotation marks have been converted to fancy-pants directional quotation marks. javascript:var js = document.createElement(‘script’);js.src = ‘ https://jwally.github.io/tadpoles-media-downloader/index.js ’;document.querySelectorAll(‘head’)[0].appendChild(js)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JWally/tadpoles-media-downloader/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS6F56ZMBNGJELJX4RZQBDUAYU7TANCNFSM5DSUKKPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.