search

JWock82 / PyNite

A 3D structural engineering finite element library for Python.
MIT License
421 stars 86 forks source link

Error Creating Members with Aux Nodes #162

Closed bjhowie closed 1 year ago

bjhowie commented 1 year ago

There is a typo in the code when creating members with auxilliary nodes defined. In the FEModel3D class, the keyword argument passed to the Physical member constructor is 'auxnode', whereas the Physical member 'init' method expects the keyword argumne to be 'aux_node'.

I'd submit a pull request, but I'm not sure i know how to, sorry.

JWock82 commented 1 year ago

Thanks for reporting this. I don't use that feature myself, so it seems to have slipped through the cracks. Looks like a simple fix.

I really need to just get the program away from aux nodes and allow the user to specify a rotation angle.

JWock82 commented 1 year ago

Pull requests are pretty easy. If you create a fork of the repository you can change the code there and then issue a pull request from your fork on Github. I think you'll get a "Pull Shark" badge on your Github profile the first time one of your pull requests is merged. If you don't want to do the pull request I can do it.

bjhowie commented 1 year ago

Yeah OK. I'll give it a try. Got to learn how to do it some day.

I quite like the aux node method of specifying member local axes as it is independent of the topology of the member. A rotation angle would differ in a member running from node 'A' to node 'B' than in one running from node 'B' to node 'A'.

JWock82 commented 1 year ago

The pull request has been merged.