search

JWock82 / Pynite

A 3D structural engineering finite element library for Python.
MIT License
454 stars 93 forks source link

Issue initalising PhysMember #183

Closed linokl closed 7 months ago

linokl commented 7 months ago

Hi Craig

I think there is a bug due to a mismatch in variable positions in the initialisation call for PhysMember

In PhysMember, when you initialise the member the super init is called with "model" variable in 10th position

image

In Member3D, in the initialisation function, "model" variable is in 6th position

image

When I am initialising the PhysMember i get an error after updating the pynite to the latest version. Possibly due to this issue I think

Regards Lino

JWock82 commented 7 months ago

That's strange. All my unit tests are passing. I'll look into this a bit closer. I just changed it, and all my unit tests failed.

JWock82 commented 7 months ago

I've corrected the code to be consistent across both classes. Newest version is v0.0.88 now.

linokl commented 7 months ago

thank you