search

JWock82 / Pynite

A 3D structural engineering finite element library for Python.
MIT License
454 stars 93 forks source link

Repair method #125

Closed maderero closed 2 years ago

maderero commented 2 years ago

New feature Fixes #100

maderero commented 2 years ago

🎉🎉🎉

maderero commented 2 years ago

There is a bit of more optimization I can do on the repair method. Do you want me to make them now, or would you rather I wait until after you bring this to master?

maderero commented 2 years ago

See this commit for more info. I have not done much testing on this since I am a bit busy today.

maderero commented 2 years ago

There is a bug in the virtual_intersection method for members that are perpendicular. The tolerance can not be set at or above 1 otherwise no intersections will be detected. This is due to the calculation that is done when calculating the denominator value. i.e. A x B = |A||B| sin θ for θ=pi/2 and normalized vectors A and B gives A x B = 1. I will propose a change later today.