proposed solution to issue #5

dmorchard commented 5 years ago

Fixes #5

Added new alternative versions of original shear, moment and displacement diagram functions within FEModel.cls. For now, the original versions have been retained and the new versions have "2" appended to their names...

GetShearDiagram2
GetMomentDiagram2
GetDispDiagram2

Added 2 new class properties to Member2D.cls which facilitate the new functions above.

dmorchard commented 5 years ago

Additional features (or lack thereof) worth mentioning...

New versions apply 12 diagram points to each segment of each member, as opposed to the original functions' 20 diagram points per member.
Did not take into consideration members' internal points of interest (i.e. local max/min or zero of V(x), M(x) or delta(x)). Although I do believe this is worth tackling in some future PR.

dmorchard commented 5 years ago

@JWock82, how have you been? If you're on board with what I've done in this PR I'll go ahead and do the same with GetAxialDiagram, which I just realized I had overlooked.

Also, I guess as a collaborator I'm technically able to click on this green "Merge pull request" button I see in front of me; however, I'd rather always leave that to you.

JWock82 commented 5 years ago

I'm OK with you merging pull requests. I don't have a ton of time to put into xlFrame at the moment as I've been working on other projects (check out building-code.herokuapp.com when you get a chance - it's a work in progress). The beauty of GitHub is that we can roll back a release if we decide a change isn't working for us.

I like the idea of picking up these points. I think it's a good idea to keep these functions separate for now. I know some of the spreadsheets I've used xlFrame for count on 20 data points to populate graphs. Using 12 points per segment makes the number of points variable, which requires re-selecting the graph data each time the loading conditions change.

One tactic you could use to keep the data to a fixed number of points is to grab the default generated point nearest to the segment boundary and move it to the segment boundary.

JWock82 / xlFrame

proposed solution to issue #5 #11