JYU-IBA / potku

Potku is analysis and simulation software for ToF-ERD measurements

https://www.jyu.fi/science/en/physics/research/infrastructures/accelerator-laboratory/pelletron/potku/

GNU General Public License v2.0

7 stars 7 forks source link

ScientificSpinbox looks and behaves differently than normal spinboxes #214

Closed tpitkanen closed 2 years ago

tpitkanen commented 3 years ago

Two different spinboxes are confusing from a user perspective. The following differences should be unified:

	Spinbox	ScientificSpinbox
Scrollable	yes	no
Font size	smaller	larger
Edit buttons	inside box	outside box

ScientificSpinbox is defined in widgets/scientific_spinbox.py and ui_files/ui_scientific_spinbox_widget.ui. Spinbox comes directly from Qt.

scientific spinbox differences

tpitkanen commented 3 years ago

@mlaitin : "spinboxes should not be scrollable"

jussiks commented 2 years ago

Inheriting from QAbstractSpinBox should fix the layout issues.

jussiks commented 2 years ago

Inheriting from QAbstractSpinBox should fix the layout issues.

Actually inheriting from QDoubleSpinBox is simpler as we only need to implement our own step function and value formatting.

tpitkanen commented 2 years ago

243 merged and augmented with combo box scroll event override.