JYU-IBA / potku

Potku is analysis and simulation software for ToF-ERD measurements
https://www.jyu.fi/science/en/physics/research/infrastructures/accelerator-laboratory/pelletron/potku/
GNU General Public License v2.0
7 stars 7 forks source link

Require re-saving cuts before calibration if beam settings have been changed #98

Open tpitkanen opened 3 years ago

tpitkanen commented 3 years ago

Problem

ToF calibration can be accessed with stale .cut files if beam settings are changed without generating new cuts.

(This is an old bug. This issue was based on an email bug report.)

Reproduction

  1. Create a request
  2. Import measurement data
  3. Make selections and save cuts that are RBS
  4. Change beam settings (e.g. beam element)
  5. Apply settings
  6. Do Detector > Calibration > Execute
  7. Observe that affected RBS cuts have the old beam in their name
tpitkanen commented 3 years ago

Workaround in c015910496debdca2105467aa30406af8c7db2e9

tpitkanen commented 3 years ago

This could be solved by keeping track of cut files and their staleness. There are probably other good uses for such feature.

Offering an option to re-save cuts for all measurements that use default settings after changing beam settings is a feasible option too.