Closed naik-aakash closed 6 months ago
Hi @JaGeo , What do you think about this changes?
Do we want to provide on MP website calc quality description text summary as well? If yes , then I will also adapt that method to work with pymatgen objects
I think only thing left to do would be writing a builder once we get some feedback that MP people are able to parse data using our schema.
@naik-aakash yeah, I think having that option would be good!
Hi @JaGeo , this PR is could be merged, if no further comments on it 😃
Attention: Patch coverage is 96.00000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 97.47%. Comparing base (
c984ab9
) to head (dc0af38
).
Files | Patch % | Lines |
---|---|---|
lobsterpy/cohp/analyze.py | 95.94% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@naik-aakash any chance to increase coverage even further? Otherwise, I will merge
@naik-aakash any chance to increase coverage even further? Otherwise, I will merge
On it, just a sec
@naik-aakash any chance to increase coverage even further? Otherwise, I will merge
On it, just a sec
I think this should be it 😄
Thank you, @naik-aakash !
Closes #220
Changes