search

JaGeo / LobsterPy

Package to perform automatic bonding analysis with the program Lobster in the field of computational materials science and quantum chemistry
https://jageo.github.io/LobsterPy/
BSD 3-Clause "New" or "Revised" License
74 stars 27 forks source link

[JOSS] Paper nitpicks #247

Closed RMeli closed 6 months ago

RMeli commented 6 months ago

Fixes a few references according to

Cite a bibliography entry by referencing its identifier: [@upper1974] will create the reference “(Upper 1974)”. Omit the brackets when referring to the author as part of a sentence: “For a case study on writers block, see Upper (1974).”

Oxford postcode used 0 instead of O (for Oxford).

RMeli commented 6 months ago

https://github.com/openjournals/joss-reviews/issues/6286

JaGeo commented 6 months ago

Thanks @RMeli !

Would it be possible for us to also thank the reviewers in the acknowledgment of the paper? Their reviews were extremely helpful.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.51%. Comparing base (f1688c2) to head (14aee25). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #247 +/- ## ========================================== - Coverage 97.70% 97.51% -0.19% ========================================== Files 12 12 Lines 2701 2701 ========================================== - Hits 2639 2634 -5 - Misses 62 67 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RMeli commented 6 months ago

Would it be possible for us to also thank the reviewers in the acknowledgment of the paper? Their reviews were extremely helpful.

Yes, you can certainly add the reviewers to the acknowledgment if you wish to do so!