search

JaGoLi / ytdl-gui

A simple-to-use, cross-platform graphical interface for youtube-dl.
GNU General Public License v3.0
256 stars 24 forks source link

option to download/embed thumbnail #39

Closed Lunarequest closed 3 years ago

Lunarequest commented 3 years ago

youtube-dl has an option to download and embed a thumbnail in the file. this is exposed with the --embed-thumbnail flag. it would be nice if this could be exposed to the user as a toggle

JaGoLi commented 3 years ago

I'm thinking about the best way to implement this. I don't want my app to have too many toggles. I want to keep it simple. I may just include it as default if it doesn't have adverse effects for people who don't care about thumbnails.

Lunarequest commented 3 years ago

it makes downloads a bit longer but it doesn't make a big difference

JaGoLi commented 3 years ago

Unfortunately, the problem is that it's only supported by two file formats: mp4 and mp3. I get the error ERROR: Only mp3 and m4a/mp4 are supported for thumbnail embedding for now for other formats. I will include that option by default for mp3 and mp4 though.

JaGoLi commented 3 years ago

I tried it out, and I can only enable it for audio and specifically mp3 format. My app prioritizes video resolution and not file format so I can't only select mp4. It does work reliably with mp3 and I have that set for default in beta branch.