JaGoLi / ytdl-gui

A simple-to-use, cross-platform graphical interface for youtube-dl.
GNU General Public License v3.0
253 stars 23 forks source link

Increase minimum version of cmake to 3.9 and enable lto #41

Closed Lunarequest closed 3 years ago

Lunarequest commented 3 years ago

since cmake 3.9 there has been an option to build with link time optimizations(lto) on compilers that support this feature(gcc,clang etc). LTO produces smaller, faster and more debugging friendly binaries. Ubuntu 21.04 enables LTO by default and arch will be implementing this soon.

note: this may cause issues when using clang as a compiler. https://bugreports.qt.io/browse/QTBUG-61710

JaGoLi commented 3 years ago

Thanks! I will merge this pull request. I will also add an if (LINUX) condition at the beginning of it to make sure it is only run on linux. MacOS and FreeBSD use clang and if this app gets ported over to them there would be issues.