UX: 'Download Succeeded' window should not be modal

JaGoLi / ytdl-gui

A simple-to-use, cross-platform graphical interface for youtube-dl.

GNU General Public License v3.0

253 stars 23 forks source link

UX: 'Download Succeeded' window should not be modal #51

Closed nobody43 closed 3 years ago

nobody43 commented 3 years ago

Or just should not pop up when main window is not active. In current behavior it interrupts user activity in other windows.

JaGoLi commented 3 years ago

What about if a download fails? Should that be modal or not in your view?

nobody43 commented 3 years ago

The point is: no notification should activate the main window. If it's not possible in Qt to suppress that - nothing should be modal.

Steps to reproduce:

start large download
do things in other windows while waiting for download to finish
swear when download finishes

JaGoLi commented 3 years ago

I have found an what is in my mind an elegant compromise. I have decided that if the youtube downloader is not the active window and the download succeeds, then there is no popup notification. However, I have decided to keep it in case of a failure. The message will still remain if downloader is in focus. I agree with you that it was very annoying in the case of long downloads.

JaGoLi commented 3 years ago

I also experimented with having the popup window be active on a timer, but it was also too distracting. Let me know what you think of this solution. You can try it in the beta branch. Also, just letting you know that this is the final feature that I will be working on before having an official 3.0 release.

JaGoLi commented 3 years ago

I'm closing this issue. I'm confident that the problem is solved.