search

JaKooLit / Arch-Hyprland

For automated installation of Hyprland on Arch or any arch based distros
GNU General Public License v3.0
1.35k stars 109 forks source link

[Feature Request]: ask for 12hr time or 24 hr time in the installer #50

Closed Sipper1236 closed 4 months ago

Sipper1236 commented 5 months ago

Feature Request

Description

I would like to see a yes or no question the asks if somone uses 24hr time or 12 hour time

Use Case

[Describe how this feature would be useful to you or to other users of the project.] it would be useful cause u dont gotta change everything to 12 hour time

Proposed Solution

[If you have a specific solution in mind, describe it here. If not, you can skip this section.]

Alternatives

[Are there any alternative solutions or workarounds that you've considered? If so, describe them here.] an alternative is to add a toggle in user settings, accessible with meta + E

Additional Information

adding the option for 12 hour time or 24 hour time allows the project to be more global [Add any other information about the feature request here. For example, you might include links to similar features in other projects, or screenshots or diagrams to help explain your idea.]

JaKooLit commented 4 months ago

hmmmmmm ill try to see what I can do

dhelgerson commented 4 months ago

+1

dhelgerson commented 4 months ago

actually since the option is already a line that needs to be uncommented, I can go ahead and submit a pr if you'd like

JaKooLit commented 4 months ago

sure you can start.. and Ill just edit as required

dhelgerson commented 4 months ago

so does your script modify files based based on user input and then install them or the other way around?

JaKooLit commented 4 months ago

You could do either.

But my plan is, it will be asked when copying the dotfiles

so you could push a PR here

https://github.com/JaKooLit/Hyprland-Dots

I was thinking of changing config before copying.

But still trying to figure out about the sddm

so probably on each distro-hyprland install script, a choice will be asked

and then depending on choice, could include on the dotfiles.sh for changes after it is copied

dhelgerson commented 4 months ago

yeah that makes a lot more sense. I'll look there.

dhelgerson commented 4 months ago

excellent work on the whole experience though. I'm thoroughly enjoying it. --also working on that PR right now.

dhelgerson commented 4 months ago

@Sipper1236, your issue has been addressed in this commit of the dev branch