[Bug]: Swaync notifications not following light/dark mode

[christophe-riolo]

Bug Report

Description

I might be one of the rare light mode user here, I noticed that the notification text was not readable in light mode, as the foreground color was not updated

After digging I found that Swaync uses the style in ~/.config/waybar/wallust/colors-waybar.css but this is not changed by DarkLight.sh so the foreground color stays #FDF1E6 when the background color is somehow changed to light I'm not sure where actually (maybe it would be just a matter of adding the foreground color in the same place)

Steps to Reproduce

1. Use the DarkLight.sh theme to switch colors
2. Check the notification that should come about the theme being changed

Expected Behavior

The text color in Swaync notifications should be changed to match the theme

Actual Behavior

Background color changes but not foreground color

Screenshots

Notification in light mode:

Environment

Not sure anything else is relevant. I used the arch install script, didn't modify the files too much, but I'd be happy to provide any extra information !

show output of inxi -CGIsSMnr install package inxi if not exist

show output here

System:
  Host: my-arch Kernel: 6.10.10-arch1-1 arch: x86_64 bits: 64
  Desktop: Hyprland v: 0.43.0 Distro: Arch Linux
Machine:
  Type: Laptop System: HP product: HP ZBook Firefly 14 inch G9 Mobile
    Workstation PC v: N/A serial: <superuser required>
  Mobo: HP model: 896D v: KBC Version 02.49.00 serial: <superuser required>
    UEFI: HP v: U70 Ver. 01.04.02 date: 11/01/2022
CPU:
  Info: 10-core (2-mt/8-st) model: 12th Gen Intel Core i7-1255U bits: 64
    type: MST AMCP cache: L2: 6.5 MiB
  Speed (MHz): avg: 733 min/max: 400/4700:3500 cores: 1: 1333 2: 400 3: 927
    4: 400 5: 965 6: 893 7: 867 8: 995 9: 400 10: 816 11: 400 12: 400
Graphics:
  Device-1: Intel Alder Lake-UP3 GT2 [Iris Xe Graphics] driver: i915 v: kernel
  Device-2: Luxvisions Innotech HP 5MP Camera driver: uvcvideo type: USB
  Display: wayland server: X.org v: 1.21.1.13 with: Xwayland v: 24.1.2
    compositor: Hyprland v: 0.43.0 driver: X: loaded: intel
    unloaded: fbdev,modesetting,vesa dri: i965 gpu: i915 resolution: 1920x1200
  API: EGL v: 1.5 drivers: iris,swrast
    platforms: gbm,wayland,x11,surfaceless,device
  API: OpenGL v: 4.6 compat-v: 4.5 vendor: intel mesa v: 24.2.2-arch1.1
    renderer: Mesa Intel Graphics (ADL GT2)
  API: Vulkan v: 1.3.295 drivers: intel surfaces: xcb,xlib,wayland
Network:
  Device-1: Intel Alder Lake-P PCH CNVi WiFi driver: iwlwifi
  IF: wlp0s20f3 state: up mac: 00:a5:54:35:45:f8
  IF-ID-1: br-741bf6014398 state: down mac: 02:42:90:b1:2a:e1
  IF-ID-2: docker0 state: down mac: 02:42:66:23:e6:57
Sensors:
  System Temperatures: cpu: 53.0 C mobo: N/A
  Fan Speeds (rpm): N/A
Repos:
  Active pacman repo servers in: /etc/pacman.d/mirrorlist
    1: https://geo.mirror.pkgbuild.com/$repo/os/$arch
    2: https://arch.mcstrugs.org/$repo/os/$arch
    3: http://mirror.arctic.lol/ArchMirror/$repo/os/$arch
    4: https://mirror.arctic.lol/ArchMirror/$repo/os/$arch
    5: http://arch.mirror.far.fi/$repo/os/$arch
    6: http://mirror.hosthink.net/archlinux/$repo/os/$arch
    7: http://arch.kyberorg.fi/$repo/os/$arch
    8: https://arch.kyberorg.fi/$repo/os/$arch
    9: http://mirror.5i.fi/archlinux/$repo/os/$arch
    10: https://mirror.5i.fi/archlinux/$repo/os/$arch
    11: https://mirror.srv.fail/archlinux/$repo/os/$arch
    12: http://mirror.wuki.li/archlinux/$repo/os/$arch
    13: https://mirror.wuki.li/archlinux/$repo/os/$arch
    14: http://arch.yhtez.xyz/$repo/os/$arch
    15: https://arch.yhtez.xyz/$repo/os/$arch
    16: http://mirror.archlinux.ikoula.com/archlinux/$repo/os/$arch
    17: http://archlinux.mirrors.benatherton.com/$repo/os/$arch
    18: http://mirror.cyberbits.eu/archlinux/$repo/os/$arch
    19: https://mirror.cyberbits.eu/archlinux/$repo/os/$arch
    20: http://archlinux.datagr.am/$repo/os/$arch
    21: https://mirrors.eric.ovh/arch/$repo/os/$arch
    22: http://mirrors.gandi.net/archlinux/$repo/os/$arch
    23: https://mirrors.gandi.net/archlinux/$repo/os/$arch
    24: https://mirror.ibakerserver.pt/Arch/$repo/os/$arch
    25: http://mirror.ibcp.fr/pub/archlinux/$repo/os/$arch
    26: http://mirror.jordanrey.me/archlinux/$repo/os/$arch
    27: https://mirror.jordanrey.me/archlinux/$repo/os/$arch
    28: https://arch.juline.tech/$repo/os/$arch
    29: http://mirroir.labhouse.fr/arch/$repo/os/$arch
    30: https://mirroir.labhouse.fr/arch/$repo/os/$arch
    31: http://mirror.lastmikoi.net/archlinux/$repo/os/$arch
    32: https://arch-mirror.cloud.louifox.house/$repo/os/$arch
    33: http://archlinux.mailtunnel.eu/$repo/os/$arch
    34: https://archlinux.mailtunnel.eu/$repo/os/$arch
    35: http://mir.archlinux.fr/$repo/os/$arch
    36: http://mirrors.celianvdb.fr/archlinux/$repo/os/$arch
    37: https://mirrors.celianvdb.fr/archlinux/$repo/os/$arch
    38: http://arch.nimukaito.net/$repo/os/$arch
    39: https://arch.nimukaito.net/$repo/os/$arch
    40: http://mirror.oldsql.cc/archlinux/$repo/os/$arch
    41: https://mirror.oldsql.cc/archlinux/$repo/os/$arch
    42: http://archlinux.mirrors.ovh.net/archlinux/$repo/os/$arch
    43: http://archlinux.rezopole.net/$repo/os/$arch
    44: https://mirrors.slaanesh.org/archlinux/$repo/os/$arch
    45: https://mirror.spaceint.fr/archlinux/$repo/os/$arch
    46: http://mirrors.standaloneinstaller.com/archlinux/$repo/os/$arch
    47: https://mirror.sysa.tech/archlinux/$repo/os/$arch
    48: https://mirror.thekinrar.fr/archlinux/$repo/os/$arch
    49: http://mirror.theo546.fr/archlinux/$repo/os/$arch
    50: https://mirror.theo546.fr/archlinux/$repo/os/$arch
    51: http://ftp.u-strasbg.fr/linux/distributions/archlinux/$repo/os/$arch
    52: https://mirror.wormhole.eu/archlinux/$repo/os/$arch
    53: http://mirroir.wptheme.fr/archlinux/$repo/os/$arch
    54: https://mirroir.wptheme.fr/archlinux/$repo/os/$arch
    55: http://arch.yourlabs.org/$repo/os/$arch
    56: https://arch.yourlabs.org/$repo/os/$arch
    57: http://ftp.acc.umu.se/mirror/archlinux/$repo/os/$arch
    58: https://ftp.acc.umu.se/mirror/archlinux/$repo/os/$arch
    59: http://ftpmirror.infania.net/mirror/archlinux/$repo/os/$arch
    60: https://ftp.ludd.ltu.se/mirrors/archlinux/$repo/os/$arch
    61: http://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch
    62: https://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch
    63: http://ftp.myrveln.se/pub/linux/archlinux/$repo/os/$arch
    64: https://ftp.myrveln.se/pub/linux/archlinux/$repo/os/$arch
    65: https://mirror.osbeck.com/archlinux/$repo/os/$arch
Info:
  Memory: total: 32 GiB note: est. available: 30.56 GiB used: 7.25 GiB (23.7%)
  Processes: 309 Uptime: 1h 29m Shell: Zsh inxi: 3.3.35

Additional Information

-

[JaKooLit]

https://github.com/JaKooLit/Hyprland-Dots/blob/main/config%2Fhypr%2Fscripts%2FDarkLight.sh#L82

not sure what dots version you have but DarkLight.sh changes noti-bg rgba and noti-bg-alt

not sure when but if I remember it correctly, recently I have changed something because during light mode, If I take a color text, its unreadable

[christophe-riolo]

It does change the noti-bg but not the text-color that is set to @foreground, a fixed color from colors-waybar.css that is unchanged (I am unsure where else this is used since waybar actually uses .config/waybar/style.css and not .config/waybar/wallust/colors-waybar.css)

But yeah, the problem is that noti-bg is changed but then the text-color doesn't match anymore

[JaKooLit]

some waybar style does use the wallust generated colors. Take note that there are multiple waybar styles to choose from

I do suggest to keep the text color at foreground because there are wallpaper and in combination with white background, text will be un readable.

BUT, you are welcome to make PR for improvement

[JaKooLit]

btw, I have tried on my system, foreground color changes

[christophe-riolo]

Hum, alright, I'll have to dig deeper into what's going wrong in my configuration, and if I find anything I'll try to make a PR !