feature: implement qtpy

JaWeilBaum / pyqtlet2

pyqtlet2 extends pyqtlet which initially brought Leaflet maps to PyQt5 and PySide6.

Other

37 stars 19 forks source link

feature: implement qtpy #28

Closed danielhrisca closed 2 years ago

danielhrisca commented 2 years ago

I've made the changes to support the generic wrapper qtpy:

drop hard requirements for PyQt5. Instead the user can install the optional dependencies for each Qt binding (for example pip install pyqtlet2[PyQt5]
if multiple Qt bindings are installed the user needs to set the qtpy environment variable before importing pyqtlet2 (for example os.environ["QT_API"] = "pyqt5" (see https://github.com/spyder-ide/qtpy/blob/36315655a04ee2197f842f0b5f3d4609489b1c7e/qtpy/__init__.py#L9)

I was able to run the demo code on all Qt bindings supported by qtpy

EasyIsrael commented 2 years ago

for me that's perfect. Wow, QWebEngineScript seems not to be used. That was the only problem, why my implementation didn't work. the rest is nearly the same as my approach.

I hope it's okay for Leon too.

JaWeilBaum commented 2 years ago

Hey guys, I was following the development here only a bit since I was super busy this week. I guess I'll have time tonight to look deeper into it! Thanks a lot for the contribution already!

JaWeilBaum commented 2 years ago

Thanks to both of you @danielhrisca and @EasyIsrael to further elaborate on this issue. I think this is a good way to go and it also teached me quite some nice thinks about pyqt! I'll update the readme.md file and then start merging and releasing the package!