search

JaWeilBaum / pyqtlet2

pyqtlet2 extends pyqtlet which initially brought Leaflet maps to PyQt5 and PySide6.
Other
37 stars 19 forks source link

Fix the creation of layers using draw control #51

Closed Baljak closed 1 year ago

Baljak commented 1 year ago

Fixes the creation of layers using the drawing control, which was no longer working since the implementation of multiple map support in version 0.9.0.

@JaWeilBaum Thanks for merging my previous PR so quickly. I have not encountered any other issues with multiple maps.

JaWeilBaum commented 1 year ago

Hi @Baljak, sorry for the longer delay now. Before I would merge this I would like to go through all parts of the code to check if there are more problems like the two you have encountered.

I hope to find some time to publish a new version on the weekend.

Baljak commented 1 year ago

Hi @JaWeilBaum, no problem.

I found another issue, although not related to multiple maps because the problem appeared also with version 0.8.3 and probably before: the "Circle Marker" drawing control does not work. The application does not crash but nothing appears on the map.

Baljak commented 1 year ago

@JaWeilBaum While fixing another bug related to the removal of layers from feature groups (I'll open a new PR later on), I actually found another issue related to the implementation of multiple maps support. As it is not specifically related to this PR, I opened a new one instead: #52.

JaWeilBaum commented 1 year ago

Hi @JaWeilBaum, no problem.

I found another issue, although not related to multiple maps because the problem appeared also with version 0.8.3 and probably before: the "Circle Marker" drawing control does not work. The application does not crash but nothing appears on the map.

Which radius do you set? I just looked up the documentation of leaflet, they state that the radius is given in pixels. Try 10000 maybe you will be able to see it.

JaWeilBaum commented 1 year ago

Closing this due to #53

Baljak commented 1 year ago

Hi @JaWeilBaum, no problem. I found another issue, although not related to multiple maps because the problem appeared also with version 0.8.3 and probably before: the "Circle Marker" drawing control does not work. The application does not crash but nothing appears on the map.

Which radius do you set? I just looked up the documentation of leaflet, they state that the radius is given in pixels. Try 10000 maybe you will be able to see it.

It's only when using the draw control that they did not appear. I opened a new PR to fix this.