Jaaap / SQRL

Secure Quick Reliable Login WebExtension for Firefox and Chrome
MIT License
64 stars 5 forks source link

Importing identity does not work on Linux #4

Open IvarSnaaijer opened 5 years ago

IvarSnaaijer commented 5 years ago

I just downloaded 0.0.32, but was not able to import my identity. The file select dialog opens, but after selecting the original dialog is gone. when I reopen the code is not imported.

Jaaap commented 5 years ago

Which Browser? Which OS?

IvarSnaaijer commented 5 years ago

That was quick ;). Firefox on linux. I'll have to check the exact versions.

IvarSnaaijer commented 5 years ago

I got this error in the console : TypeError: Argument 1 of MutationObserver.observe is not an object. content-script.js:189:5

Firefox 65.0 (64-bits) (Dutch locale) on Ubuntu 18.04.2 LTS

IvarSnaaijer commented 5 years ago

I tried to reproduce on a blank page, but the console does not show the error, turned add-on debugging on, does not help. I have no idea what I'm doing ;) Could you point me to a resource on how to help you? Is there something I can do to help ?

I looked at the code, I expect onIdentityfileChange to fire, but I have not debugged an extension yet.

Jaaap commented 5 years ago

I'll try it on a Linux box when i have access to one.

IvarSnaaijer commented 5 years ago

I might be able to facilitate that. is there a way to send a more private message ? You can send me a mail if you add a @ and .nl to obvious places.

IvarSnaaijer commented 5 years ago

Also, i took the time to read the main page.... I installed the code in chrome and I get the same thing. So at least it is consistent. I do not have the Firefox Development edition, Chrome sounds like a better option for this kind of debugging.

nst0022 commented 5 years ago

This is not Ubuntu-specific.

I get this strange behavior (pop-up window vanishes whenever it loses focus) also on Debian (both in Google Chrome and in Chromium, latest versions).

I have no other extensions that use pop-up windows and I could not find anything conclusive on the Internet, except someone who claimed that this is intended behavior by Google.

From a user experience perspective this would be a quiet disturbing feature :-).

IvarSnaaijer commented 5 years ago

I installed the extension in Firefox 65.0.1 on a Windows 10 machine and get the same result. Importing does not seem to function. nst0022 might be on to something.

sesam commented 5 years ago

the extension "pop-out" window disappears?

Sorry if I'm off the track, this is my best guess from several recent issues.

Maybe this and other issues can be solved by moving all interactive/wizardy features to a separate page, since then it won't disappear easily. The pop-down is probably best reserved for single click features. HTH

Jaaap commented 5 years ago

Ah yes this is a known issue on Linux and Windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1366330 Doesn't look like they're gonna fix it anytome soon :( I'll work on it.

nst0022 commented 5 years ago

Wow, excellent research :-). In that bug report, there is another referenced, where someone said "If you want a popup that isn't transient, then use noautohide.". Could that be a solution, is there a window property "noautohide" you could set?

uphlewis commented 5 years ago

Is there a workaround for now, for importing an identity ??

shanedk commented 5 years ago

Trying this on my Ubuntu laptop, and the Browse button is greyed (blued?) out and I can't click it. Was this a temporary measure while this bug is being fixed, or is there something else going on?

I also don't have an option to scan a QR code, so my only option is text import. Is this correct?

uphlewis commented 5 years ago

@shanedk How would you scan a QR code on your laptop screen using your laptop? From a desktop machine youd probably click on it, which would open the sqrl:// link in your browser right ?

shanedk commented 5 years ago

@uphlewis I'm talking about importing the identity. My laptop has a camera, so it'd be great to be able to scan the QR code to import the identity instead of having to do the textual import.

Jaaap commented 5 years ago

This should be fixed in version 0.0.40 which has been submitted to Mozilla and Google.

sesam commented 4 years ago

Ping: is this solved with 0.40 or newer?