search

JaapvanEkris / openrowingmonitor

A free and open source performance monitor for rowing machines
GNU General Public License v3.0
27 stars 7 forks source link

Backend redesign #6

Closed carlito1979 closed 1 year ago

carlito1979 commented 1 year ago

Hi Jaap,

I've tested your change, and it worked, but there were a couple of other minor bugs that I've attempted to fix. The biggest one is that the timer (which appears to be governed by the flywheel?) wasn't resetting back to zero when the rower presses the reset button on the web client.

carlito1979 commented 1 year ago

Apologies Jaap, I won't push through another pull request as I clearly don't understand what I'm doing with them.

Your changes worked properly, so thanks for resolving those issues for me. I'm looking forward to seeing your engine changes make their way into the main branch in the near future!

JaapvanEkris commented 1 year ago

Apologies Jaap, I won't push through another pull request as I clearly don't understand what I'm doing with them.

I know the feeling, so no problem. Changes have been added to the Backend_Redesign branch.