search

JabRef / JabRefOnline

https://www.jabref.org
MIT License
32 stars 10 forks source link

Download link is invisible #2158

Closed Siedlerchr closed 1 year ago

Siedlerchr commented 1 year ago
grafik

Related https://community.uploadcare.com/t/tailwind-css-reset-causes-the-background-for-the-main-button-to-be-white/2032

dmbaturin commented 1 year ago

The button seems visible for me now, but the text color choice for its non-hover version seems atrocious regardless: image

k3KAW8Pnf7mkmdSMPHz27 commented 1 year ago

There will be a follow-up PR to https://github.com/JabRef/JabRefOnline/pull/2135.

I believe both the color and transparency issue is addressed in becem-gharbi/nuxt-naiveui version 1.2.4+

dmbaturin commented 1 year ago

Wait, it's merged but it's still not on the live version of jabref.org? I'm a bit confused.

k3KAW8Pnf7mkmdSMPHz27 commented 1 year ago

@dmbaturin it is merged, but not deployed. In a nutshell, when someone has available time they'll have to look at,

  1. Configuring the new version of nuxt-naiveu appropriately and remove the workaround that is currently merged in main
  2. Making sure that the changes are deployed through the GitHub Actions workflow

I am trying to look at 1. in my spare time, but someone else might beat me to it since I am not a Vue/frontend developer :stuck_out_tongue:

Siedlerchr commented 1 year ago

Deployment fails currently for some various reasons @tobiasdiez any idea how to fix this?

k3KAW8Pnf7mkmdSMPHz27 commented 1 year ago

@Siedlerchr I believe you have more context in https://github.com/Azure/static-web-apps-cli/issues/721

k3KAW8Pnf7mkmdSMPHz27 commented 1 year ago

There is also this https://stackoverflow.com/questions/54309021/azure-nodejs-dist-directory-error-ebusy-or-files-silently-not-overriden

See https://github.com/JabRef/JabRefOnline/blob/1a25e5ad22e28e4897fc40d29af08d4561045922/.github/workflows/deploy.yml#L61-L69

Siedlerchr commented 1 year ago

Why do we execute this on Windows? Does not make sense to me. From what I read and see this should also work on linux Powershell is also available on unix systems

Siedlerchr commented 1 year ago

Fixed the deployment but DL link is not working https://dev.www.jabref.org/

Siedlerchr commented 1 year ago

Fixed by https://github.com/JabRef/JabRefOnline/commit/3c0b75b5f9c7a1ba16351d6534c7883c83849fb6

tobiasdiez commented 1 year ago

Still needs a proper fix.

Siedlerchr commented 1 year ago

It was fixed by https://github.com/JabRef/JabRefOnline/commit/e5585024af82d80edfdfd93b07c7c0236e5ef1da

grafik

but as the deployment was not working I first had to fix the github workflow.

tobiasdiez commented 1 year ago

Okay right, but this PR was not yet ready as its broke the storybook ui tests...