search

JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.52k stars 2.47k forks source link

Make Show Preferences Window searchable #1019

Closed Siedlerchr closed 5 years ago

Siedlerchr commented 8 years ago

It would be nice to have an incremental search field for searching through the Prerferences in the "Show Prefences" window

koppor commented 8 years ago

Refs #113, #268.

Think, we should really wait for the JavaFX port.

stefan-kolb commented 8 years ago

It's a nice idea however I'd rather have it in the preferences window itself than in the Show preferences view. Like in Intelij or Eclipse to find configuration options easier without knowing in which subsection to look for.

I'd close this issue though for know as this should be done when refstructuring the preferences tab #382.

WtfJoke commented 5 years ago

Is this still up for grabs? I would give it a try. Never contributed to your project, though. If I cant make it, I'll write here again.

I would try it to design like @stefan-kolb mentioned

Siedlerchr commented 5 years ago

Yes, this is still open. It would be really nice to have it integrated in the preferences window as a tab and to have it searchable

koppor commented 5 years ago

Good opportunity to learn and apply JavaFX. We welcome your contribution! Happy #hacktoberfest!

Manuel notifications@github.com schrieb am Mi., 17. Okt. 2018, 10:50:

Is this still up for grabs? I would give it a try. Never contributed to your project, though. If I cant make it, I'll write here again.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/JabRef/jabref/issues/1019#issuecomment-430544718, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTaftfnsFwpAnTls3OGvmULHeWUFyJyks5ulu9rgaJpZM4H2AlI .

tobiasdiez commented 5 years ago

You might have a look at how the search is implemented in https://github.com/dlemmermann/PreferencesFX .

paulKra commented 5 years ago

Hi, we are two students looking for open source project to participate in and found this issue through the awesome beginners list. Is this issue still open? Can we start working on it?

Or is @WtfJoke still working on this?

WtfJoke commented 5 years ago

@paulKra I started working on it. Since I am limited on time, I am still in the beginning but still want to do it, hope you guys dont mind :)

koppor commented 5 years ago

Could you three join forces? This task is not that small and it would be a pity if work was stopped in the half... If @paulKra would start working and creating a WIP pull request, @wtfjoke could step in? Or you could have a sync call? 😇

Manuel notifications@github.com schrieb am Fr., 26. Okt. 2018, 15:55:

@paulKra https://github.com/paulKra I started working on it. Since I am limited on time, I am still in the beginning but still want to do it, hope you guys dont mind :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/JabRef/jabref/issues/1019#issuecomment-433416037, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTafixhbC1TsyhxcYP2TTHspEESnnCqks5uoxRHgaJpZM4H2AlI .

WtfJoke commented 5 years ago

I dont mind doing this together. Im up for a chat/call with @paulKra and your friend.

CaptainDaVinci commented 5 years ago

I would like to work on implementing this, unless it's still being worked on by someone?

Siedlerchr commented 5 years ago

There is a PR from someone who started working on it,but not finished. Maybe you can ask the authors or reuse some commits. There is also another issue from me which is about the window showing all preferences and searching in there. That would be awesome if you could implement it

Yash Kothari notifications@github.com schrieb am Fr., 8. März 2019, 20:33:

I would like to work on implementing this, unless it's still being worked on by someone?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/JabRef/jabref/issues/1019#issuecomment-471049114, or mute the thread https://github.com/notifications/unsubscribe-auth/AATi5K0ypwD6p7g436OvdXy72uu91Mvuks5vUrsbgaJpZM4H2AlI .

WtfJoke commented 5 years ago

I didnt forget about the issue/pr (see https://github.com/JabRef/jabref/issues/4415) but still havent found time to progress. :see_no_evil:

@CaptainDaVinci you can continue on my branch. I invited you to my repo. I did some basics and the remaining part is about marking the found entries

WtfJoke commented 5 years ago

How is this related now to https://github.com/JabRef/jabref/pull/4759?

Siedlerchr commented 5 years ago

The show all preferences window (the table view). is now searchable . The preferences window itself not yet.

tobiasdiez commented 5 years ago

Thanks to @WtfJoke and @CaptainDaVinci this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

WtfJoke commented 5 years ago

I took the latest master (JabRef-5.0-dev--snapshot--2019-03-28--master--a73167933.jar) and search looks fine for me.

I have however one note: If I search a term, which is not in the currently selected settings view (eg. I have opened Advanced View and search for something which is in General View), then the view doesnt switch.

I think in terms of user experience, it would be great to switch to any (or the first) view, which contains the term, if there any hits.

Not sure if should create a separate issue for that.

tobiasdiez commented 5 years ago

@WtfJoke yes please open a new issue for it. It's a useful suggestion.

CaptainDaVinci commented 5 years ago

I have implemented the changes suggested by @WtfJoke , is it okay if I push the changes on the same branch where the search was implemented?

WtfJoke commented 5 years ago

Nice :) Probably you should create a separate branch from the latest master (since the search branch got already merged)

CaptainDaVinci commented 5 years ago

There is also an issue of buttons not being highlighted. Also, under external programs tab the buttons Settings for * are inside a grid pane and aren't considered when searching.