JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.49k stars 2.46k forks source link

Migrate library fields after confirmation. Store selected migration preference inside library #10370

Open koppor opened 10 months ago

koppor commented 10 months ago

I claim: If one opens a .bib file with JabRef, save it and close it, the file is not modified

However, JabRef migrates the field review to comment without any user information. This should not happen.

Proposal:

  1. In case JabRef wants to do a migration, then it asks for the user (example: pdf field)
  2. The answer to the migration choice should be stored in the library

Note on 1: A list of migrations to be performed would be nice. The user can then add and remove migrations on demand.

Links:

koppor commented 9 months ago

As far as I remember, the decision to automatically migrate review was done, because our check in 2015 revealed that review was a custom JabRef field and not used by any other software. We also wanted to streamline the code and support only the latest release version of JabRef.

koppor commented 9 months ago

Code:

https://github.com/JabRef/jabref/blob/c444c739d62737003fd1c178d3aeefb628fe78b1/src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java#L55

and

https://github.com/JabRef/jabref/blob/c444c739d62737003fd1c178d3aeefb628fe78b1/src/main/java/org/jabref/logic/importer/OpenDatabase.java#L33

koppor commented 8 months ago

Implementation hints were given at https://github.com/JabRef/jabref/pull/3658#discussion_r168779345. Follow-up at https://github.com/JabRef/jabref/pull/3733.

koppor commented 3 months ago

Code merging the fields at org.jabref.migrations.MergeReviewIntoCommentMigration.