JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.63k stars 2.59k forks source link

Windows not opened correctly on Gnome #10729

Open Doc73 opened 10 months ago

Doc73 commented 10 months ago

JabRef version

5.12 (latest release)

Operating system

GNU / Linux

Details on version and operating system

Debian Sid Gnome

Checked with the latest development build (copy version output from About dialog)

Steps to reproduce the behaviour

  1. Click on add a new entry or other command which opens a new window
  2. See the window

Here is a screenshot.

Schermata del 2023-12-27 17-42-16

Appendix

...

Log File ``` Paste an excerpt of your log file here ```
Siedlerchr commented 10 months ago

Thanks for the screenshot. Indeed looks odd. Which gnome version are you using? Can you resize the window or is it stuck?

Doc73 commented 10 months ago

Debian Sid is now on Gnome 44.7 and yes: I can resize the window!

Siedlerchr commented 10 months ago

Does the https://builds.jabref.org/main/ 5.13 make any difference?

Doc73 commented 10 months ago

@Siedlerchr No: same issue

SECtim commented 10 months ago

I can confirm the same issue on XFCE (XUbuntu 22.04) with both 5.12 and 5.13 (installed via snap).

JabRef 5.12--2023-12-24--4233bad
Linux 6.2.0-39-generic amd64 
Java 21.0.1 
JavaFX 21.0.1+6
JabRef 5.13--2023-12-27--23b75db
Linux 6.2.0-39-generic amd64 
Java 21.0.1 
JavaFX 21+31

Edit: I can also resize the window - and if I do that after expanding the list of entry types, I can see all entry types and select one as usual, except for missing scrolling if the window overflows:

  1. Is the selection window right after opening it.
  2. After clicking "Others".
  3. After a slight resizing, note the lack of scroll bars (and I cannot scroll with the mouse wheel either).
  4. After resizing enough to fit everything.

image

Siedlerchr commented 10 months ago

For comparison: This is what it looks like on mac

grafik

expanded:

grafik

So a solution would be to make it scrollable and to adjust the min size/pref width of the dialog and maybe also store the size of the dialog.

Doc73 commented 10 months ago

@Siedlerchr This issue started with latest version. What is changed in this release?

ilippert commented 10 months ago

same issue in JabRef 5.13--2024-01-03--bd92577 Linux 6.6.8-200.fc39.x86_64 amd64 Java 21.0.1 JavaFX 21+31

Siedlerchr commented 10 months ago

Can you all try if this version works ? https://builds.jabref.org/pull/10747/merge I downgraded javafx so we can narrow it down that the update was the culprit

Doc73 commented 10 months ago

@Siedlerchr Yes! This version works well!

Siedlerchr commented 10 months ago

Thanks for the feedback. I will report it to the javafx-team as bug. I have prepared a minimal reproducer project https://github.com/Siedlerchr/javafxreproducer/actions/runs/7413688805 (just download the artifact, extract the zip and run image/bin/app

Can you please verify that this also displays weird? It should look something like this:

grafik
SECtim commented 10 months ago

@Siedlerchr The reproducer looks normal (i.e., like in your screenshot) for me (on XFCE).

Can you all try if this version works ? https://builds.jabref.org/pull/10747/merge I downgraded javafx so we can narrow it down that the update was the culprit

That version works for me.

However, at least for me, the "add entry" dialog only looks weird once I expand the list of entry types (i.e., unfold "Others"). In other words: The issue seems to be a that the dialog window does not get resized automatically - as far as I can see, the reproducer does not need any automatic window resizing?

Sorry for the many edits here... I just noticed that even just moving the dialog window brings me from state 2 to 3 (see my post with screenshots above).

Furthermore, the dialog seems to "invisibly" resize itself: After unfolding "Others", if I move the cursor somewhere in the "empty" area of the dialog, e.g., below the "ID" field and leave it there, I see a help text for the WWW entry type (which, when I carefully resize the window, appears in exactly that position). I can also click there and get a new WWW entry. image

Siedlerchr commented 10 months ago

Thanks for the hint, I have updated the reproducer to make it more like the original dialog https://github.com/Siedlerchr/javafxreproducer/actions/runs/7423389210

SECtim commented 10 months ago

The updated reproducer looks like this (right after starting it): image

The issue would maybe show up if the "Others" is closed by default.

Siedlerchr commented 10 months ago

Okay I have prepared a new version https://github.com/Siedlerchr/javafxreproducer/actions/runs/7424320620

SECtim commented 10 months ago

Before unfolding "Other": image

and afterwards: image

I.e., it does not automatically resize. However, it is not exactly the same as for JabRef: The buttons seem to actually "vanish" instead of being there, just not visible as in the case of the JabRef dialog. I'm not sure whether that is relevant though, just wanted to mention it.

Siedlerchr commented 10 months ago

Okay, thanks. I am currently setting up a VM with gnome to test this as well there to file a bug report

Doc73 commented 10 months ago

Unfortunately, I'm not at home and I can't do any test before Sunday

Siedlerchr commented 10 months ago

I updated my reproducer example and could reproduce the issue under Gnome 42.9 Wayland under Ubuntu 22.04. I just submitted a bug report to the javafx folks

Siedlerchr commented 9 months ago

I am curious, does the new build here work? https://builds.jabref.org/pull/10808/merge

Doc73 commented 9 months ago

@Siedlerchr In this version the window still does not resize automatically. See, for example

Schermata del 2024-01-20 22-16-58

and then

Schermata del 2024-01-20 22-17-06

Siedlerchr commented 9 months ago

Okay thanks for the feedback, will check the bug again and report it again

Domenico Cufalo @.***> schrieb am So., 21. Jan. 2024, 00:45:

@Siedlerchr https://github.com/Siedlerchr In this version the window still does not resize automatically. See, for example

Schermata.del.2024-01-20.22-16-58.png (view on web) https://github.com/JabRef/jabref/assets/1306260/66c70b47-249f-4602-bf73-15b9e27aef83

and then

Schermata.del.2024-01-20.22-17-06.png (view on web) https://github.com/JabRef/jabref/assets/1306260/c48be1f6-da3b-4800-aeb2-42b90ac0b5e0

— Reply to this email directly, view it on GitHub https://github.com/JabRef/jabref/issues/10729#issuecomment-1902424308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOFZHGEM3VZPCGYFFTNJLYPRJLNAVCNFSM6AAAAABBERW5COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGQZDIMZQHA . You are receiving this because you were mentioned.Message ID: @.***>

Siedlerchr commented 9 months ago

The bug is now confirmed on the JDK/javafx side: https://bugs.openjdk.org/browse/JDK-8324423

koppor commented 9 months ago

Removed from milestone, since a) depends on external and b) the dialogs open "somehow". We could downgrade to JavaFX 20, but then menus do not open at all on i3, which is worse than this issue.

koppor commented 7 months ago

From now and then, one could try a build from https://builds.jabref.org/jdk-ea/ - Each week, we try to use the newest development builds from Oracle's JavaFX. Sadly, the builds are not updated that regularly (https://mvnrepository.com/artifact/org.openjfx/javafx) than Oracle states they have a build ready (https://jdk.java.net/javafx23/)

koppor commented 3 months ago

https://www.java.com/releases/matrix/ --> Some time in July

koppor commented 3 months ago

Removed from closer tracking, because we will update JavaFX as soon as there will be a new release.

wujastyk commented 3 months ago

JabRef 5.16--2024-08-05--a28cfd2 Linux 6.8.0-39-generic amd64 Java 22.0.2 JavaFX 23-ea+27

The issue I reported at https://github.com/JabRef/jabref/issues/11589#issue-2450474426 is not resolved by https://builds.jabref.org/jdk-ea/