JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.49k stars 2.46k forks source link

Support for (biblatex) langid field in entry editor #10868

Open jspitz opened 5 months ago

jspitz commented 5 months ago

JabRef 5.12

I might have overlooked it, but I do not find the rather central langid field in the entry editor. This field defines the principal language of the entry, which is important for hyphenation and whether (sentence) casing is applied. There is also langidopts for fine-tuning (with polyglossia)

The field is described in http://mirrors.ctan.org/macros/latex/contrib/biblatex/doc/biblatex.pdf at section 2.3.3

In my opinion, this should go to the "Optional" tab.

Siedlerchr commented 5 months ago

Thanks for the suggestion. In the meantime you can configure the field under Custome entry types. JabRef's Standard fiels are listed here https://github.com/JabRef/jabref/blob/13870d831e5d98d27127c4f8d9ec67f199d298be/src/main/java/org/jabref/model/entry/field/StandardField.java We only have "language" as standard field atm

jspitz commented 5 months ago

Thanks for the suggestion. In the meantime you can configure the field under Custome entry types.

Thanks, that's what I've done.

Skydrite commented 5 months ago

Hello. Can I work on this issue? Thank you!

github-actions[bot] commented 5 months ago

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

Skydrite commented 4 months ago

Hey, seeing this issue in more detail, it looks to me that the only thing needed to add the 'langid' field is to add it on the StandardFields. Next, I think I will have to work on the exporter so that it exports this info. However, I'm not sure whether I need to work on the importers as well (or which of them). Is there any maintainer who would be able to discuss this with me a bit?

koppor commented 4 months ago

@Skydrite Just start with the StandardField. No worries about importers. They will emerge gradually. -- Also depends on https://github.com/JabRef/jabref/pull/11013/.

koppor commented 3 months ago

Closed by https://github.com/JabRef/jabref/pull/11049

jspitz commented 3 months ago

If I am not missing something, the langid field still is not among the optional fields of any biblatex entry type in JabRef 5.13. #11049 just added it to the fields known by JabRef.

So this request is actually not fully addressed.

koppor commented 3 months ago

@jspitz Sorry that we did not review thoroughly at https://github.com/JabRef/jabref/pull/11049

Seems, the requirements were not clear.

The field needs to be added as optional field to all biblatex entry types