search

JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.54k stars 2.47k forks source link

the unit test in ACSTest need to update #11734

Open leaf-soba opened 1 week ago

leaf-soba commented 1 week ago

JabRef version

5.15 (latest release)

Operating system

macOS

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

Steps to reproduce the behaviour

  1. run unit test method findByDOI in ACSTest
    • failed reason:the link of this case https://pubs.acs.org/doi/pdf/10.1021/bk-2006-STYG.ch014 become "Page Not Found" 2024-09-09 15 16 59
  2. I checked all elements in another page but it don't have element a.button_primary, which is used in org.jabref.logic.importer.fetcher.ACS to find Fulltext PDF, maybe it need fix to use another method to check whether Fulltext PDF exists or not.

Appendix

...

Log File ``` Paste an excerpt of your log file here ```
Siedlerchr commented 1 week ago

@koppor You already took a look at the AcsFetcher, right?

koppor commented 1 week ago

Yes, used to try other scraping frameworks. See commits at https://github.com/koppor/jabref/pull/695