redo and undo buttons are active without open library

[Siedlerchr]

          Hello @koppor , I noticed an error yesterday. Maybe, You want to examine. the error is like this:

redo and undo buttons become active when the project is up and running:

When you click on these buttons, an error message appears like this:

Originally posted by @melisolmez in https://github.com/JabRef/jabref/issues/463#issuecomment-2376639604

[HoussemNasri]

I like it when Java throws an exception at line 53 in a class having 42 lines of code :)

[faresbouzayen]

Hi @Siedlerchr! I'm interested in fixing the redo and undo buttons being active without an open library.

Plan: Investigate how the button state is managed. Implement logic to enable buttons only when a library is open. Test thoroughly to ensure correct behavior. Update documentation as needed. I'll start looking into this and reach out if I have questions. Thanks!

[koppor]

I think @melisomez is already on it at https://github.com/JabRef/jabref/pull/11839

[Siedlerchr]

It's related but not the same. we need to integrate an additional check e.g. this.executable.bind(needsDatabase(stateManager)

[melisolmez]

I think @melisomez is already on it at #11839

Actually I am not. I am working on listener just.

[github-actions[bot]]

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[subhramit]

Hi @Siedlerchr! I'm interested in fixing the redo and undo buttons being active without an open library.

Plan: Investigate how the button state is managed. Implement logic to enable buttons only when a library is open. Test thoroughly to ensure correct behavior. Update documentation as needed. I'll start looking into this and reach out if I have questions. Thanks!

Hey @faresbouzayen, are you actively working on this? I see that you have not even forked the repository yet. Do you need any help? If busy, you can pass this on to other students.

[faresbouzayen]

Yes you can assign to someone else

[subhramit]

@maintainers shift this to free-to-take.

[damgam0288]

Hi @Siedlerchr I'm part of a group of five students looking to contribute to this project as part of an assignment.

Our plan for this issue:

• [ ] Understand how the Undo/Redo buttons enabled/disabled state is managed, specifically what causes the state to change.
• [ ] Investigate the use of "libraryTab" referring to the posted stacktrace.
• [ ] Implement logic between button state and library's open/closed state.
• [ ] Write tests and documentation.
• [ ] Submit a PR if we appear to have solved the issue.

We plan to focus on this for the next 1-2 weeks if assigned. We will engage through the comments, and state if we cannot solve this issue so that it is available to others promptly. Thanks!