nicksw
commented
5 years ago Hi. Does anyone mind if I try to fix this one?
Closed JoKalliauer closed 5 years ago
nicksw
commented
5 years ago Hi. Does anyone mind if I try to fix this one?
tobiasdiez
commented
5 years ago Sure, go ahead!
nicksw
commented
5 years ago Hello,
I am a bit confused on the exact source of this error. I read through the corresponding classes from the Event-Log, but most issues should be caught. Only suspect is line 435 in org.jabref.gui.mergeentries.MergeEntries. It reads ...get(2).... when there are only two options avail. If the user selected two, the fields would clear other than the title, as it is reserved and would throw an error. Any Help would be appreciated.
tobiasdiez
commented
5 years ago Thanks for investing this issue! My guess is that in
https://github.com/JabRef/jabref/blob/611ac556408b23ce9426a290e83c7375a480a989/src/main/java/org/jabref/gui/mergeentries/MergeEntries.java#L443
entryPreview is null. It is initialized in the constructor
https://github.com/JabRef/jabref/blob/611ac556408b23ce9426a290e83c7375a480a989/src/main/java/org/jabref/gui/mergeentries/MergeEntries.java#L182-L187
but this happens on a different thread/async, while the call
https://github.com/JabRef/jabref/blob/611ac556408b23ce9426a290e83c7375a480a989/src/main/java/org/jabref/gui/mergeentries/MergeEntries.java#L206
is immediate. If this analysis is correct indeed, then I would suggest to simply move the updateAll call to the end of runInJavaFXThread code.
cszhilu1998
commented
5 years ago @tobiasdiez I did what you said, but it seems that the dialog is stuck. https://github.com/1160300909/jabref/blob/master/src/main/java/org/jabref/gui/mergeentries/MergeEntries.java
Siedlerchr
commented
5 years ago Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.
We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.
JoKalliauer
commented
5 years ago @Siedlerchr I tried with:
JabRef 5.0-dev--snapshot--2018-08-24--master--f43b9c7e8
Linux 4.15.0-32-generic amd64
Java 1.8.0_181and now the merging-window appears :-D , but my desktop freezes :-( Which is worse than doing nothing.
Siedlerchr
commented
5 years ago As the merge window is still an old swing dialog, it might be hidden
Siedlerchr
commented
5 years ago @JoKalliauer Okay, I could get a total freeze on my Ubuntu VM as well. Please try this workaround. This worked for me.
java -jar -Djavafx.embed.singleThread=true JabRef.jar
JoKalliauer
commented
5 years ago @Siedlerchr
Thanks: java -jar -Djavafx.embed.singleThread=true JabRef.jar worked with:
JabRef 5.0-dev--snapshot--2018-08-24--master--f43b9c7e8
Linux 4.15.0-33-generic amd64
Java 1.8.0_181
JabRef 5.0-dev--snapshot--2018-07-12--master--dd9b22911 Linux 4.15.0-29-generic amd64 Java 1.8.0_181
Steps to reproduce:
Event-log
Opening: /home/jkalliau/ownCloud/PhDJK/LaTeX/Style/BugRep.bib runCommand error: null java.lang.NullPointerException at org.jabref.gui.mergeentries.MergeEntries.updateAll(MergeEntries.java:443) at org.jabref.gui.mergeentries.MergeEntries.initialize(MergeEntries.java:206) at org.jabref.gui.mergeentries.MergeEntries.