search

JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.58k stars 2.5k forks source link

Icons in Entry Edit Window not visible in Dark Mode #7853

Closed dirkziegenbalg closed 3 years ago

dirkziegenbalg commented 3 years ago

JabRef version 5.3--2021-06-27--aa60dd6 on Windows 10

I have tested the latest development version from http://builds.jabref.org/main and the problem persists

The icons in the entry edit window are frequently too dark to be visible in dark mode. A bright color would be better suited

Steps to reproduce the behavior:

  1. change to dark mode
  2. edit an entry
  3. view icons
Screenshot 2021-06-28 132651
JJJoex commented 3 years ago

I think we can redesign the dark-theme by adjusting the color of components then it will looks prettier. And Is there anyone work on the issue?

Siedlerchr commented 3 years ago

@Joe11028 Thanks for your interest! Feel free to work on this! 'You will find the Dark Theme and the Base.css here https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/gui/Dark.css

See also this reference guide for the javafx componnents https://openjfx.io/javadoc/16/javafx.graphics/javafx/scene/doc-files/cssref.html

JJJoex commented 3 years ago

@Siedlerchr Okay, thank you for providing informations. I think we should only changed the specific components' color rather than redesign the dark theme, I will try my best to work on this issue.

JJJoex commented 3 years ago

@Siedlerchr I'm now can sure the issue caused by the icon from the imported package(org.kordamp.ikonli.materialdesign). The icons' color can not be changed after we switch to dark theme. So we have two ways to solve this issue: Add another set of icons that suitable for dark theme. Or don't modify icons, but let the icon-button background color be different from the main body background color, so you can find the icons(buttons) easily. How do you think of that and which one would you prefer?