search

JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.62k stars 2.57k forks source link

When changing a group color, no dialog should appear #8189

Closed koppor closed 2 years ago

koppor commented 3 years ago

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 10

Checked with the latest development build

Steps to reproduce the behaviour

  1. Edit the properties of a group
  2. Change the color
  3. Click "OK"
  4. Dialog "Change of Grouping Method" appears
    grafik

Expected behavior: No dialog appears, just the group color should change

Refs https://github.com/JabRef/jabref/issues/7325

Appendix

No response

koppor commented 3 years ago

No triggered reassignment should then also keep the git diff noise to a minimum

Currently, following diff is generated:

grafik

Siedlerchr commented 2 years ago

I looked a bit into it, the dialog is called here:

A solution would be to check if there have been changes to the group type or group keywords etc and only display that dialog in this cases.

https://github.com/JabRef/jabref/blob/9d1c448bb828d344aa773a66eaa60ac6bcc1dfad/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java#L183-L199

dimitrisdimos00 commented 2 years ago

Hello there. In which cases is a warning useless except from when changing the color? For example, I'm thinking that when changing the icon of the group, no warning should be shown either. Do we need a warning only for the "Hierarchical context" and "Collect by" options?

dimitrisdimos00 commented 2 years ago

Hello?

Siedlerchr commented 2 years ago

Sorry, missed your question. I guess it makes only sense when the group type or for example the keywords or the separator changed. For color and icon not

Surabhiramesh commented 2 years ago

Hi, we are a group of students studying Master of Computer Science in University of Adelaide and we wanted to check if this issue is available for us to work on for our assignment. And if it is available, we would like to get some valuable inputs based on the previous contributions to this issue.

koppor commented 2 years ago

In which cases is a warning useless except from when changing the color? For example, I'm thinking that when changing the icon of the group, no warning should be shown either.

You are right. Please make a list of all possible cases, where a) no dialog should be opened and b) where a dialog should be opened

Do we need a warning only for the "Hierarchical context" and "Collect by" options?

I am not sure. It should be properly documented and JUnit tests should exist.

koppor commented 2 years ago

@Surabhiramesh The issue is available. Please go ahead. Please also see my last comment.

ThiloteE commented 2 years ago

Welcome and thank you for your engagement. Guidelines for contributing can be found here: https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md. See here for a rough outline of this process. In general, it is advised to open a (draft) pull request early on so that reviewers have time to comment and the general direction of the request becomes clear. This will allow you to receive valuable feedback!

If you have any questions, feel free to ask! Either here at GitHub, or you also can join our gitter chat.