'Copy DOI URL' in entry list only copies DOI but not the URL

ytzemih commented 2 years ago

JabRef version

Latest development branch build (please note build date below) JabRef 5.5--2022-01-03--c94bb1b Linux 5.11.0-44-generic amd64 Java 16.0.2 JavaFX 17.0.1+1

Operating system

GNU / Linux

Details on version and operating system

Ubuntu 20.04

Checked with the latest development build

[X] I made a backup of my libraries before testing the latest development version.
[X] I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

In the entry list, right-click on a URL symbol in the URL column and chose menu item "Copy ... -> Copy DOI URL"
Paste from clipboard and you will only see the DOI pasted.
Now, open that entry in the entry editor, go to "Optional fields", right-click on DOI and chose menu item "Copy DOI URL".
Paste from clipboard and you will see the DOI URL pasted.

Siedlerchr commented 2 years ago

HI, welcome to JabRef! The first step is always trying to reproduce the issue. Then to find the differences. As a staring point, the MainTable code for copying is somewhere in org.jabref.gui.maintable.RightClickMenu and the other one (for the field in the Entry Editor) And for the other one you should take a look in org.jabref.gui.fieldeditors.contextmenu.EditorMenus

When you have a fix follow the guide and create a new PR.

Siedlerchr commented 2 years ago

I tested it and it works. For consistency reasons, I would also add the Copy DOI and Copy DOI Url context menu to the entry editor

JabRef / jabref