search

JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.61k stars 2.57k forks source link

Avoid hiding the background tasks status indicator on smaller window sizes #8781

Closed claell closed 2 years ago

claell commented 2 years ago

Is your suggestion for improvement related to a problem? Please describe. On smaller window sizes, the status indicator (and button) for background tasks is hidden. I think such an indicator should never be hidden.

Describe the solution you'd like Possibly change its location or never hide it at its current place.

Additional context grafik

ThiloteE commented 2 years ago

Related: #8295

ThiloteE commented 2 years ago

Could potentially be solved by implementing #8774 and moving the other buttons slightly to the left. I think, there is some space between the search bar and the other buttons.

claell commented 2 years ago

Agreed. Probably the responsive design behavior can be improved.

Just wanted to keep the issue description neutral to the solution (moving the button might help to improve discoverability and highlighting the special nature of it, for example).

0CoolMichael commented 2 years ago

This question is quite interesting and I will try to do it in this moment. After modifying the position of the button, I will submit a pull request.

ThiloteE commented 2 years ago

Of course you can. You might want to coordinate and communicate with @Beingmani so as to not create any merge conflicts. He wants to work on #8774, which is very closely related.

Beingmani commented 2 years ago

Yes, i do. I already worked on it and it should fix the issue. Fixing #8774 will fix this.

Will raise a PR by tomorrow :)

Beingmani commented 2 years ago

Hey Guys,

Solution :

Moving the Background task button to the front will resolve the issues on smaller screens and since it's responsive, it will be the first one that is visible even on smaller screens.

Here is a picture of the screen where the solution is implemented. I'm trying to get rid of the space but this solution works for now I guess. let me know if I can draft a PR for this.

image

claell commented 2 years ago

@Beingmani I read that you wanted to add a PR by yesterday. Are there current problems occurring that you need help with? Also, is that screenshot a mockup or an already implemented solution?

Additionally, please have a look at #8795, which is related. Maybe, you can work on that basis.

claell commented 2 years ago

Just saw that you are working on https://github.com/Beingmani/jabref/commits/main, so adding for reference.

Beingmani commented 2 years ago

Hi @claell , The screenshot is from my local jabref where I made code changes.

8795 - Regarding this, I can see that there is space that is left intentionally for text (i.e n entries found) .

Moving the Background task button to front should actually fix these issues.

calixtus commented 2 years ago

As I wrote in the other PR, I don't think the the backgroundtask-indicator is important enough to be displayed right next to the search bar. The space is there because there is a hidden label that (as i remember) displays the number of hits of a search query. The space can probably removed if no search query is entered (managedProperty).

claell commented 2 years ago

Removing the space (and adding it again after a query) will likely lead to "jumping" icons, though. I think that is why it has not been done before.

ThiloteE commented 2 years ago

on 1366x768 dpi

grafik

To summarize: Would really be good to always display "background task status indicator" even on small screens, because that would likely be a workaround to triggering the error. Edit: Yes I also agree It should not be displayed prominently on the left. In my opinion, the following buttons are very important too:

grafik grafik

Edit2: Maybe one could enable disable groups of buttons via view? Just like one can hide the groups panel or websearch. But maybe this is overkill.

claell commented 2 years ago

That spaces are currently set on purpose:

Here you can see where the width is set for the left spacer. https://github.com/JabRef/jabref/blob/6a2332f6b17c818a7f091647b102e7099d36569e/src/main/java/org/jabref/gui/JabRefFrame.java#L541

I think, that this can be done more responsive (like on Firefox for example). The space around the search and address bar dynamically changes depending on the window width.

koppor commented 2 years ago

In the devcall, we decided to move forward with the less intrusive solution of https://github.com/JabRef/jabref/pull/8798. That solution works in smaller window sizes equal to 1280x960 or bigger than that.