JabRef / jabref

Graphical Java application for managing BibTeX and biblatex (.bib) databases
https://devdocs.jabref.org
MIT License
3.6k stars 2.56k forks source link

Citation Key is overwritten when importing bibtex code with ctrl+v even when the generator is disabled. #9455

Open MKHoffmann opened 1 year ago

MKHoffmann commented 1 year ago

JabRef version

5.7 (latest release)

Operating system

Windows

Details on version and operating system

JabRef 5.7--2022-08-05--73c111c Windows 11 10.0 amd64 Java 18.0.2 JavaFX 18.0.1+2

Checked with the latest development build

Steps to reproduce the behaviour

  1. Disable Citation Key Generator
  2. Copy a bibtex citation code from Google Scholar
  3. Import it using ctrl+v
  4. Citation Key is changed to something different.

Appendix

No response

ThiloteE commented 1 year ago

With "disable Citation Key Generator" you mean to disable "Overwrite existing keys" in the preferences? image

ThiloteE commented 1 year ago

Related issues/PRs:

koppor commented 1 year ago

We think, our preferences are not well organized in this respect. Please check following setting

grafik

koppor commented 1 year ago

Since requires internal refactorings, we postpone this after the release of v5.8.

MKHoffmann commented 1 year ago

Yes, all these settings are disabled. I should add, I am using Jabref on a Windows 11 machine.

koppor commented 1 year ago

Our test case:

Library without following entry:

@Article{test-key-not-generated,
  author = {Test Author},
}
  1. Use JabRef build as of today (not 5.7)
  2. Run on Windows 10
  3. Copy the entry from GitHub to the clipbard
  4. Paste entry

Result:

grafik

Video of it https://www.loom.com/share/d5098caf604e456296169fa68841d09e

MKHoffmann commented 1 year ago

For version 5.8 and Windows 11: If I paste your test case, this is my output: image With the settings: image

koppor commented 1 year ago

Oh, wow. Can you

  1. Export your preferences (small arrow on the lower left side on the dialog) - and send them to us (web -> jabref.org)
  2. Reset the preferences (if that is OK for you)
  3. Change both (!) preferences again. The thing is, in your case, JabRef DOES NOT check "Overwrite existing keys", but uses "Generate new key on for imported antries". In other words: It does not matter what you ticket at "Overwrite existing keys", because this is about the behavior of the manual triggering of the key generator, not the logic running when importing an entry.
  4. Check again
MKHoffmann commented 1 year ago

Sure, I will do that, how should I send it though? Via the forum or what is the preferred way?

Siedlerchr commented 1 year ago

you can send a mail to web@jabref.org

MKHoffmann commented 1 year ago

Thank you, I sent the preference settings and tried your steps, the problem still occurs.

Siedlerchr commented 1 year ago

Maybe related issue? https://github.com/JabRef/jabref/issues/8644

MKHoffmann commented 1 year ago

Yes, that helped, thank you!