search

Jabb0 / CatchAllBird

CatchAll support Addon for Thunderbird
Mozilla Public License 2.0
7 stars 2 forks source link

Make compatible with Thunderbird 128 #31

Closed Fersaar closed 3 days ago

Fersaar commented 1 month ago 
make compatible with Thunderbird v128
change to manifestV3
npm audit fixes

First of all, thank you for your work on this extension. When I tried to test it with Thunderbird v128, I got the attached error messages. The latest Thunderbird version seems to no longer fully support some parts of v2. The PR is my first work with Thunderbird extensions, so I may have overlooked something.

Fixed errors: messages_ ist deprecated deprecated2

Jabb0 commented 1 month ago

Hi @Fersaar, thank you for the contribution!

I will review it.

Jabb0 commented 1 month ago

Add this here for reference: https://webextension-api.thunderbird.net/en/beta-mv3/changes/128.html

Fersaar commented 1 month ago

Hey @Jabb0, thanks for the review, I have updatet the PR and you can test it.

Jabb0 commented 3 days ago

LGTM thanks!

I found that the error image

I think the document.addEventListener("DOMContentLoaded", load); is called too often.
I think this is not related to your changes here, they just surfaced them.

Jabb0 commented 3 days ago

@Fersaar hey.

The service worker migration does not work as expected. In v3 background jobs are ephemeral.

I did the following:

  1. Started the addon
  2. Wrote an email to myself.
  3. upon closing the window and receiving the mail, I get the error shown in my earlier message.

The background page is restarted and thus the listeners are created/called again.