Jabba-Team / jabba

(cross-platform) Java Version Manager
Apache License 2.0
141 stars 11 forks source link

Support 32bit Windows hosts #13

Closed saschpe closed 1 year ago

saschpe commented 1 year ago

This is a little cumbersome to test without a release but I ran both the shell script and the PowerShell script on a Windows 10 32bit host and checked it tries to download the correct binary. Afterwards, I copied the 32bit jabba binary manually to ~/.jabba/bin/jabba and verified it works.

patrick-mccourt commented 1 year ago

Thanks for contributing this @saschpe, changes look good to me. An excellent point around the testing of builds being a bit manual.

The way I've been doing it is using the make install command in the makefile. It installs the latest git tag locally, so I create a git tag and then run make install. I have raised a task to review the install procedure (though I've not done anything with it yet!)