Jacajack / vscode-glsl-linter

GLSL linter for Code
5 stars 1 forks source link

Validator Args #3

Closed jeffw387 closed 4 years ago

jeffw387 commented 4 years ago

I'm trying to set up for linting targeting vulkan/spir-v, so I was attempting to pass "-V" to the compiler. When I pass any arguments (that I've tried so far) the linter seems to silently fail.

Here's the relevant section of settings.json

"glsl-linter.validatorPath": "/usr/bin/glslangValidator",
"glsl-linter.validatorArgs": "-V",
"glsl-linter.fileExtensions": {},
Jacajack commented 4 years ago

Indeed, it seems that any non-empty string causes it to fail. I'll look into it today. Thanks for reporting! :+1:

Jacajack commented 4 years ago

Now, for more clarity validatorArgs is an array. I also improved error handling a bit, so you should be notified if glslangValidator fails. I hope this helps!

jeffw387 commented 4 years ago

Thanks for the quick response! I'll try it out soon.