Jacalz / rymdport

Cross-platform application for easy encrypted file, folder, and text sharing between devices.
https://rymdport.github.io/
GNU General Public License v3.0
1.08k stars 53 forks source link

Build RichText segments without parsing markdown #117

Closed Jacalz closed 11 months ago

Jacalz commented 1 year ago

Checklist

Is your feature request related to a problem?

For the QR-code and information dialog we are currently parsing markdown to build the text. We can set the required RichText regiments directly without having to parse a markdown string each time.

Describe the solution you'd like to see.

Set RichText segments directly. Hopefully it means that the markdown parser is dead code eliminates leading to smaller binaries (not sure how tightly coupled it is in Fyne or how smart the Go compiler is there).

GalihFajar commented 11 months ago

HI, is this issue available to be taken? Might need to explore first though, but I want to give it a try. Thanks!

Jacalz commented 11 months ago

It is indeed available to be taken. As long as no one is assigned it is fine. However, I haven't tested that it is better than parsing markdown.

GalihFajar commented 11 months ago

Appreciate it, could you help assign it to me?

GalihFajar commented 11 months ago

I've submitted the PR here.

I've built the code on the arm64 and it indeeds reduce the binaries smaller for about 2.3%.

Jacalz commented 11 months ago

Thanks for looking at it. I've assigned you to the issue and will try to review the PR later today :)