JacekBialek / PriceIndices

A package for Bilateral and Multilateral Price Index Calculations
11 stars 3 forks source link

price_indices not working properly #3

Open amurguiag opened 1 year ago

amurguiag commented 1 year ago

Hello,

I am using price_indices() with a data frame that contains the necessary columns and their correct data type. The data contains 6 different product IDs, each with non-missing price and quantities values for 59 time periods. I am currently testing it with formula ="tornqvist" and interval = TRUE. However, the output throws me NaNs for all the time periods except the first. It's a fairly simple query, but it is giving me that issue. If the dataset is grouped at earlier stages, it throws me this error (so I make sure the data is ungrouped before feeding it to the function):

Capture

Before this new version of the package (0.1.3), I tested my same data with price_index() and it also did not work. I would get that same error above. In my attempts to solve the issue, I set prodID = 1 throughout all the groups. It ran and the function outputted values that seemed reasonable. But the function is not aggregating and averaging price changes accurately given this tweak of mine. Not surprisingly, price_indices() spits the same result with this tweak on prodID.

I would like to ask if there's anything I am missing about this function, price_indices().

Thanks for your time.

JacekBialek commented 1 year ago

Hi, the easiest way to verify it is to test the function on your data set. Could you send me a sample data set? My email adress is jacek.bialek@uni.lodz.pl. I will try to help, I do not suppose that the PriceIndices works wrong - perhaps data set has some drawback... Let me check, ok?