JaciBrunning / Pathfinder

Cross-Platform, Multi-Use Motion Profiling and Trajectory Generation
MIT License
255 stars 78 forks source link

Update deps #34

Closed SUPERCILEX closed 6 years ago

SUPERCILEX commented 6 years ago

@JacisNonsense bump

JaciBrunning commented 6 years ago

I'm holding off on merging this until I have some time to bundle some more stuff along with this.

SUPERCILEX commented 6 years ago

K

JaciBrunning commented 6 years ago

Is there a specific reason the deps need to be updated? PF builds just fine with old deps

SUPERCILEX commented 6 years ago

Gradle wasn't updated properly so this PR does that. Also, is there a reason not to keep things up-to-date? 😕

JaciBrunning commented 6 years ago

It's moreso keeping master up to date with the current release. No need to push an updated version of the library if it's only the build system that gets updated

SUPERCILEX commented 6 years ago

There's #35 which makes debugging waaaaaay easier.

SUPERCILEX commented 6 years ago

@JacisNonsense Is this good to go?

JaciBrunning commented 6 years ago

This won't make any changes to how pathfinder functions - it's stable on the current deps in master. Is there any reason you want to update the build system if nothing's changed? Pathfinder doesn't depend on any other libraries.

SUPERCILEX commented 6 years ago

So it doesn't become legacy code?

SUPERCILEX commented 6 years ago

@JacisNonsense Now that the season is over, don't see a reason not to merge.

SUPERCILEX commented 6 years ago

@JacisNonsense bump