search

Jack000 / Expose

A simple static site generator for photoessays
MIT License
4.39k stars 257 forks source link

Add option for h265 encoded video #9

Closed StephenBrown2 closed 9 years ago

StephenBrown2 commented 9 years ago

HEVC is becoming a thing and is available in the latest ffmpeg, so why not use it?

I also set it and vp9 as default ahead of h264 and vp8, but I'll be glad to change that back to what it was instead.

Jack000 commented 9 years ago

so the reason I didn't set vp9 as default is because it takes like 10x the amount of time to encode vs h264, and if you set it to a faster setting it tends to lose its compression advantages. So if you want it, it's there as an option, but right now I'm not sure it should be the default.

The issue with h265 is that you need to compile ffmpeg yourself (I think?) to have that encoder. I agree that it should be available, but I'll have to install my ffmpeg with the lib and test it a bit before adding to the repo.

Jack000 commented 9 years ago

ok, looks good. Please set the defaults back and I'll merge it.

StephenBrown2 commented 9 years ago

Hey, thanks for the merge. I see @bmtm already reverted the defaults so I'll just delete my branch and things should be good.

Thanks again for sharing your project!

Jack000 commented 9 years ago

oh yeah that's my account. Made that user for a jekyll site, not sure why it defaults to it.

Thanks for the pull request!