JackBuck / Robo-Plot

The main repository for our hackspace project.
2 stars 0 forks source link

Issue - #114 minor adjustments #115

Closed JackBuck closed 7 years ago

JackBuck commented 7 years ago

@Hsenrab

Hsenrab commented 7 years ago

All changes look fine, If we wanted to we could probably increase the tolerance further to 0.2 or 0.5 mm. We could also put all the debugging functionality on separate threads not just the saving (although I think this is where most of the time is lost).

JackBuck commented 7 years ago

That's true - we should see if the above threading is enough and thread more of it if not. It would just be slightly more complicated to introduce some sort of message pipe for the add_point() method (i.e. that is, if we want to remove the copy for the numpy array before the save, but really that should be super fast anyway).

JackBuck commented 7 years ago

Sorry @Hsenrab , I've just added something to avoid accidentally trying to draw an svg with a greater resolution than the evaluation_tolerance can cope with (e.g. the default resolution in the Curve.follow() method).

Hsenrab commented 7 years ago

This needs to be merged carefully do any new scripts are updated to using plotter home/draw/follow