#117 :: Added function and test to translate paths from camera co-ord…

JackBuck / Robo-Plot

The main repository for our hackspace project.

2 stars 0 forks source link

#117 :: Added function and test to translate paths from camera co-ord… #148

Closed Hsenrab closed 7 years ago

Hsenrab commented 7 years ago

…inates to global co-ordinates using camera offset.

I have already merged it back as I need the functionality but this means the commits are separated for you to look at.

JackBuck commented 7 years ago

You have a bug where in both the test and the camera_utils module, you use config.camera_offset, but in the config file, you actually define config.CAMERA_OFFSET. Hence the tests pass but in real life, your translate_camera_points_to_global_points function will not work! (Pycharm pointed this out to me with red underlines - did it not for you?)

Other than that, the only thing I can see is some unused imports 😉 in test_translate_camera_points.py and camera_utils.py.

@Hsenrab