search

JackDanger / permanent_records

Rails Plugin - soft-delete your ActiveRecord records. It's like an explicit version of ActsAsParanoid
https://jdanger.com
MIT License
272 stars 64 forks source link

Update to rails 5 #103

Closed msalzburg closed 5 years ago

msalzburg commented 5 years ago

This PR supports rails 5.x and is tested against current ruby versions (between 2.2.10 and 2.6.5). To support rails 5.2 the PR #100 from @nancy-cai has been incorporated. The ruby target version of rubocop has been bumped to ruby 2.2. Because of conflicting dependencies the Rails 4.2 support has been dropped.

I would recommend to release a new gem version (#98) of the current master branch before merging this PR and releasing a gem version with rails 5.x support.

msalzburg commented 5 years ago

@JackDanger any thoughts?

JackDanger commented 5 years ago

This is fantastic work, @msalzburg. Let's do it!

To make our work easier in the future I've configured pushing new gem versions via GitHub Actions. So you can open a PR that changes the VERSION file and any maintainer can merge that, releasing a new gem.