search

JackDanielsAndCode / react-native-multi-slider

Pure JS react native slider component with one or two markers.
MIT License
151 stars 96 forks source link

Update values #18

Closed mrlaessig closed 8 years ago

mrlaessig commented 8 years ago

I think this is a more declarative way to update the marker positions by updating the values prop. Instead of calling set(values) through refs to change the slider values programmatically.

I removed the RN dependency, because a RN project with a different RN version will cause naming collisions. And RN is available in a RN project anyways.

@jrans Would it be an option to switch to the RN Animated API to update the marker position during update or drag? This would enable more smooth animations.

jrans commented 8 years ago

Thanks for this! Good idea. Tbh, I'd love to rewrite it all when I have the time off work! Feel free to submit the PR to solve this but hopefully I can jump back on this soon enough.