JackDanielsAndCode / react-native-multi-slider

Pure JS react native slider component with one or two markers.
MIT License
151 stars 96 forks source link

Support for React Native >= 0.49 #49

Closed wkoutre closed 1 year ago

wkoutre commented 6 years ago

Changed View.propTypes to first check for ReactNative.ViewPropTypes if user is on RN >= 0.49

adamhaney commented 6 years ago

I've been using this as a dependency pinned to @wkoutre's branch/commit and it's been working well for me, any reason to not merge this into the mainline?

wkoutre commented 6 years ago

Second to this. Just simple updates coinciding with React Native monthly releases, as well as a few other minor things.

rafinskipg commented 6 years ago

@JackDanielsAndCode please merge this

rafinskipg commented 6 years ago

@adamhaney how did you point to @wkoutre version? I'm trying with no luck, (if you can please provide a really dumb example)

I'm doing this: "react-native-multi-slider": "git@github.com:wkoutre/react-native-multi-slider.git#469aca48c610394d66fab278622d0c33de992b11", But yarn still tries to select one version

wkoutre commented 6 years ago

@rafinskipg You probably have to delete your yarn.lock file and reinstall your dependencies.

In my own projects’ package.json, I have this:

"react-native-multi-slider": "https://github.com/wkoutre/react-native-multi-slider"

I’d create a separate npm package for it but... it hardly seems necessary considering this is such a simple PR.

adamhaney commented 6 years ago

@rafinskipg I'm doing this

    "react-native-multi-slider": "wkoutre/react-native-multi-slider#469aca4",

You might also want to follow the above advice of running rm -rf node_modules/ if you have any further trouble.